-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for both Qtip and UDP traffic for Server Listeners. #4803
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
==========================================
+ Coverage 85.92% 86.86% +0.94%
==========================================
Files 56 56
Lines 17425 17729 +304
==========================================
+ Hits 14973 15401 +428
+ Misses 2452 2328 -124 ☔ View full report in Codecov by Sentry. |
@@ -1139,4 +1139,4 @@ CxPlatTryAddSocket( | |||
} | |||
|
|||
return Status; | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will address this.
…tion, all pinging the same listener
- name: Fix log permissions for Linux XDP | ||
if: failure() && matrix.vec.plat == 'linux' # (matrix.vec.plat == 'linux' && matrix.vec.xdp == '-UseXdp') doesn't work for some reason | ||
run: | | ||
sudo chmod -R 777 artifacts | ||
- name: Upload on Failure | ||
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why these action changes are showing up in my diff - is the PR based on an older commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the PR is based on an older commit.
Description
Currently, we have an execution parameter (QUIC_EXECUTION_CONFIG_FLAG_QTIP) that you set to either process packets via QTIP or normal QUIC/UDP traffic.
For a server listener, that means you can only talk to clients with the same execution profile as you; you either deal over QTIP or QUIC/UDP.
This is inconvenient and sometimes a blocker when you want your listener to accept from clients with varying execution parameters (QTIP through the Azure load balancer, normal QUIC/UDP for on-prem clients)
Closes: #3516
Testing
Test modifications are required to ensure normal QUIC/UDP endpoint is still supported when you set the QUIC_EXECUTION_CONFIG_FLAG_QTIP parameter.
Documentation
N/A