Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for both Qtip and UDP traffic for Server Listeners. #4803

Open
wants to merge 73 commits into
base: main
Choose a base branch
from

Conversation

ProjectsByJackHe
Copy link
Contributor

@ProjectsByJackHe ProjectsByJackHe commented Feb 7, 2025

Description

Currently, we have an execution parameter (QUIC_EXECUTION_CONFIG_FLAG_QTIP) that you set to either process packets via QTIP or normal QUIC/UDP traffic.

For a server listener, that means you can only talk to clients with the same execution profile as you; you either deal over QTIP or QUIC/UDP.

This is inconvenient and sometimes a blocker when you want your listener to accept from clients with varying execution parameters (QTIP through the Azure load balancer, normal QUIC/UDP for on-prem clients)

Changes
The main behavior change is that now all Server listeners created will accept both QTIP and QUIC+udp traffic by default when XDP is configured and running correctly.

To support this new design and make testing a bit easier, we also add a knob at the connection layer to control whether a connection created is going to send QUIC+udp/QTIP.

This pull-request also updates the behavior of QUIC_EXECUTION_CONFIG_FLAG_QTIP: If you set this flag, all client connections created will default to using QTIP unless otherwise specified. Note that the QUIC_EXECUTION_CONFIG_FLAG_QTIP does not impact server Listeners as they will always accept both QUIC/QTIP traffic assuming XDP is configured and running correctly.

This PR adds an API (connection Get/Set parameter) for client connections to specify whether the connection sends normal QUIC and/or TCP traffic.

Closes: #3516

Testing

Modified a datatest to alternate between creating normal QUIC connections and QTIP connections, where they all ping the same listener. The expectation is all the tests pass.

Documentation

N/A

@ProjectsByJackHe ProjectsByJackHe requested a review from a team as a code owner February 7, 2025 20:49
@ProjectsByJackHe ProjectsByJackHe marked this pull request as draft February 7, 2025 20:49
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (9073911) to head (90a469a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4803      +/-   ##
==========================================
- Coverage   86.20%   85.25%   -0.96%     
==========================================
  Files          56       56              
  Lines       17726    17751      +25     
==========================================
- Hits        15281    15133     -148     
- Misses       2445     2618     +173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ProjectsByJackHe ProjectsByJackHe added Partner: SQL By or For the SQL team Area: Lola Related to low latency work Area: API labels Feb 13, 2025
@ProjectsByJackHe ProjectsByJackHe marked this pull request as ready for review March 6, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API Area: Lola Related to low latency work Partner: SQL By or For the SQL team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for QTIP and UDP on QUIC
3 participants