`powerplatform_tenant_isolation_policy` resource #618

mattdot · 2025-03-05T23:53:05Z

This pull request introduces a new tenant_isolation_policy resource to enforce tenant isolation settings, along with various other improvements and additions. The most important changes include the addition of new resource documentation, updates to the testing and development environment configurations, and the implementation of the necessary API client and models for the new resource.

New Resource Addition:

Added new tenant_isolation_policy resource to enforce tenant isolation settings. This includes the creation of the necessary API client, models, and resource schema. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Documentation:

Added comprehensive instructions for the Terraform Provider Power Platform, covering compilation, linting, testing, and best practices.
Added new documentation for the tenant_isolation_policy resource, including example usage and schema details.

Testing and Development Environment:

Updated .devcontainer/devcontainer.json to include the GitHub.copilot-chat extension.
Added a new launch configuration for attaching to a process in .vscode/launch.json. [1] [2]
Added testing guidance to ensure proper organization and execution of unit and acceptance tests.

Linter Configuration:

Updated .golangci.yml to allow for a higher number of issues per linter and the same issues, increasing the limits from 1 to 10.This pull request includes several changes, primarily focusing on adding support for tenant isolation policies, updating development configurations, and improving documentation. The most important changes are summarized below:

Tenant Isolation Policy Support:

Added a new resource powerplatform_tenant_isolation_policy to manage tenant isolation policies. This includes the necessary API client, DTOs, and resource models. [1] [2] [3] [4]

Documentation:

Added detailed instructions for development tasks in .github/copilot-instructions.md, including commands for compiling code, running linters, and executing tests.
Created a new documentation file for the powerplatform_tenant_isolation_policy resource in docs/resources/tenant_isolation_policy.md.

Development Configuration:

Updated .devcontainer/devcontainer.json to include the GitHub.copilot-chat extension.
Modified .vscode/launch.json to add a new configuration for attaching to a process and to use the integrated terminal for debugging. [1] [2]

Linter Settings:

Increased the maximum number of issues per linter and the maximum number of the same issues in .golangci.yml.

Examples:

Added example configurations for the powerplatform_tenant_isolation_policy resource in examples/resources/powerplatform_tenant_isolation_policy/resource.tf and examples/tenant-isolation/main.tf. [1] [2]

…pport

PR Overview

Adds support for the new powerplatform_tenant_isolation_policy resource while also improving related documentation, development configurations, and linter settings.

Introduces API client, DTOs, and models to enable management of tenant isolation policies.
Provides detailed documentation and example usage for the new resource.
Updates development configuration files and test registration to include the new resource, and increases linter thresholds.

Reviewed Changes

File	Description
docs/resources/tenant_isolation_policy.md	Added documentation, example usage, and schema details for the tenant isolation policy resource.
internal/services/tenant_isolation_policy/api_tenant_isolation_policy.go	Introduces the API client with methods to get and create/update tenant isolation policies, including async polling.
internal/services/tenant_isolation_policy/dto.go	Defines the DTOs for tenant isolation policy, including nested properties for allowed tenants.
internal/services/tenant_isolation_policy/models.go	Provides the Terraform resource model for tenant isolation policies.
.github/copilot-instructions.md	Updates instructions for building, testing, and linting, ensuring developers have clear guidelines.
.golangci.yml	Increases linter thresholds, adjusting the maximum issues reported per linter.
internal/provider/provider.go	Registers the new tenant isolation policy resource and updates provider resources accordingly.
internal/provider/provider_test.go	Updates tests to verify that the new tenant isolation policy resource is correctly registered.

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

internal/services/tenant_isolation_policy/api_tenant_isolation_policy.go:116

Consider adding unit tests to specifically cover the async polling logic and error paths in DoWaitForLifecycleOperationStatus to ensure it behaves correctly under different HTTP status responses and header values.

func (client *Client) DoWaitForLifecycleOperationStatus(ctx context.Context, response *api.Response) (*TenantIsolationPolicyDto, error) {

…ion names

…n settings

…source

…hance testing guidance

…ttps://github.com/microsoft/terraform-provider-power-platform into 612-powerplatform_tenant_isolation_policy-resource

.changes/unreleased/added-20250306-042937.yaml

internal/services/tenant_isolation_policy/api_tenant_isolation_policy.go

mawasile · 2025-03-06T17:02:58Z

internal/services/tenant_isolation_policy/api_tenant_isolation_policy.go

+
+	if resp.HttpResponse.StatusCode == http.StatusAccepted {
+		// Handle async operation
+		_, err := client.DoWaitForLifecycleOperationStatus(ctx, resp)


you can add retry logic here, I have example on #622

I don't see how this is relevant to this particular operation

so you don't want to have a retry here?

It already has retry logic because it uses execute which does retries. I don't know why 622 isn't using the standard retry logic.

internal/services/tenant_isolation_policy/api_tenant_isolation_policy.go

internal/services/tenant_isolation_policy/resource_tenant_isolation_policy.go

internal/services/tenant_isolation_policy/resource_tenant_isolation_policy_test.go

…source

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

… code comments

… logging

…on_policy.go for improved performance

…d consistency

…r clarity

…source

internal/services/tenant_isolation_policy/api_tenant_isolation_policy.go

internal/services/tenant_isolation_policy/resource_tenant_isolation_policy.go

internal/services/tenant_isolation_policy/resource_tenant_isolation_policy_test.go

internal/services/tenant_isolation_policy/resource_tenant_isolation_policy.go

…rganization

…cy tests

…e checks

github-actions[bot] added 2 commits March 5, 2025 10:04

Feat: Add tenant isolation policy resource and related DTOs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

78130b5

Feat: Implement tenant isolation policy resource and add debugging su…

Loading
Loading status checks…

8c0fc21

…pport

mattdot self-assigned this Mar 5, 2025

mattdot linked an issue Mar 5, 2025 that may be closed by this pull request

powerplatform_tenant_isolation_policy resource #612

Open

10 tasks

mattdot requested a review from Copilot March 5, 2025 23:54

Copilot AI reviewed Mar 5, 2025

View reviewed changes

github-actions[bot] and others added 4 commits March 6, 2025 01:30

Refactor: Remove unused Terraform example and update test setup funct…

Loading
Loading status checks…

b837348

…ion names

Chore: Update .gitignore and enhance test coverage in makefile

Loading
Loading status checks…

33df6b9

Feat: Add tenant isolation policy resource to enforce tenant isolatio…

043e3c0

…n settings

Merge branch 'main' into 612-powerplatform_tenant_isolation_policy-re…

5c1045a

…source

mattdot marked this pull request as ready for review March 6, 2025 04:46

mattdot requested review from mawasile, leighatami, ianjensenisme, polatengin and eduardodfmex as code owners March 6, 2025 04:46

mattdot added the ai assisted label Mar 6, 2025

github-actions[bot] added 2 commits March 6, 2025 21:41

Feat: Add test JSON files for tenant isolation policy resource and en…

386388b

…hance testing guidance

Merge branch '612-powerplatform_tenant_isolation_policy-resource' of h…

110543d

…ttps://github.com/microsoft/terraform-provider-power-platform into 612-powerplatform_tenant_isolation_policy-resource

mawasile requested changes Mar 7, 2025

View reviewed changes

mawasile and others added 5 commits March 7, 2025 13:29

Merge branch 'main' into 612-powerplatform_tenant_isolation_policy-re…

50e469b

…source

Update added-20250306-042937.yaml

5440d9f

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

Update resource_tenant_isolation_policy.go

473231b

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

Enhance documentation for tenant isolation policy methods and improve…

bb4ee27

… code comments

Refactor tenant isolation policy methods for improved readability and…

965fde2

… logging

mattdot requested a review from mawasile March 8, 2025 05:40

github-actions[bot] and others added 4 commits March 8, 2025 05:51

Remove unnecessary sorting of tenant lists in resource_tenant_isolati…

66f6e84

…on_policy.go for improved performance

Rename tenant isolation policy test functions for improved clarity an…

3979971

…d consistency

Remove redundant comments in tenant isolation policy documentation fo…

5ea76ee

…r clarity

Merge branch 'main' into 612-powerplatform_tenant_isolation_policy-re…

cf7c8a6

…source

mawasile requested changes Mar 11, 2025

View reviewed changes

eduardodfmex reviewed Mar 11, 2025

View reviewed changes

internal/services/tenant_isolation_policy/resource_tenant_isolation_policy.go Outdated Show resolved Hide resolved

github-actions[bot] added 7 commits March 12, 2025 03:49

Update copilot instructions for clarity and organization

a6df84e

Fix: Set IsDisabled to true in tenant isolation policy deletion

95d2860

Refactor: Move DTO conversion functions to separate file for better o…

d62f904

…rganization

Remove redundant import state verification from tenant isolation poli…

120b7e6

…cy tests

Add JSON test cases for tenant isolation policy validation

e9bebe3

Remove obsolete error JSON for invalid tenant ID validation

54589f4

Enhance getRetryAfterDuration: implement minimum and maximum wait tim…

c7ff5af

…e checks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`powerplatform_tenant_isolation_policy` resource #618

`powerplatform_tenant_isolation_policy` resource #618

mattdot commented Mar 5, 2025 •

edited

Loading

mawasile Mar 6, 2025

mattdot Mar 8, 2025

mawasile Mar 11, 2025

mattdot Mar 12, 2025

powerplatform_tenant_isolation_policy resource #618

Are you sure you want to change the base?

powerplatform_tenant_isolation_policy resource #618

Conversation

mattdot commented Mar 5, 2025 • edited Loading

New Resource Addition:

Documentation:

Testing and Development Environment:

Linter Configuration:

Tenant Isolation Policy Support:

Documentation:

Development Configuration:

Linter Settings:

Examples:

Choose a reason for hiding this comment

PR Overview

Reviewed Changes

mawasile Mar 6, 2025

Choose a reason for hiding this comment

mattdot Mar 8, 2025

Choose a reason for hiding this comment

mawasile Mar 11, 2025

Choose a reason for hiding this comment

mattdot Mar 12, 2025

Choose a reason for hiding this comment

`powerplatform_tenant_isolation_policy` resource #618

`powerplatform_tenant_isolation_policy` resource #618

mattdot commented Mar 5, 2025 •

edited

Loading