powerplatform_tenant_isolation_policy resource
#618
+1,597
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
There was a problem hiding this comment.
PR Overview
Adds support for the new powerplatform_tenant_isolation_policy resource while also improving related documentation, development configurations, and linter settings.
- Introduces API client, DTOs, and models to enable management of tenant isolation policies.
- Provides detailed documentation and example usage for the new resource.
- Updates development configuration files and test registration to include the new resource, and increases linter thresholds.
Reviewed Changes
| File | Description |
|---|---|
| docs/resources/tenant_isolation_policy.md | Added documentation, example usage, and schema details for the tenant isolation policy resource. |
| internal/services/tenant_isolation_policy/api_tenant_isolation_policy.go | Introduces the API client with methods to get and create/update tenant isolation policies, including async polling. |
| internal/services/tenant_isolation_policy/dto.go | Defines the DTOs for tenant isolation policy, including nested properties for allowed tenants. |
| internal/services/tenant_isolation_policy/models.go | Provides the Terraform resource model for tenant isolation policies. |
| .github/copilot-instructions.md | Updates instructions for building, testing, and linting, ensuring developers have clear guidelines. |
| .golangci.yml | Increases linter thresholds, adjusting the maximum issues reported per linter. |
| internal/provider/provider.go | Registers the new tenant isolation policy resource and updates provider resources accordingly. |
| internal/provider/provider_test.go | Updates tests to verify that the new tenant isolation policy resource is correctly registered. |
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
internal/services/tenant_isolation_policy/api_tenant_isolation_policy.go:116
- Consider adding unit tests to specifically cover the async polling logic and error paths in DoWaitForLifecycleOperationStatus to ensure it behaves correctly under different HTTP status responses and header values.
func (client *Client) DoWaitForLifecycleOperationStatus(ctx context.Context, response *api.Response) (*TenantIsolationPolicyDto, error) {
mattdot
requested review from
mawasile,
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
mattdot
added
the
ai assisted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes, primarily focusing on adding support for tenant isolation policies, updating development configurations, and improving documentation. The most important changes are summarized below:
Tenant Isolation Policy Support:
powerplatform_tenant_isolation_policyto manage tenant isolation policies. This includes the necessary API client, DTOs, and resource models. [1] [2] [3] [4]Documentation:
.github/copilot-instructions.md, including commands for compiling code, running linters, and executing tests.powerplatform_tenant_isolation_policyresource indocs/resources/tenant_isolation_policy.md.Development Configuration:
.devcontainer/devcontainer.jsonto include theGitHub.copilot-chatextension..vscode/launch.jsonto add a new configuration for attaching to a process and to use the integrated terminal for debugging. [1] [2]Linter Settings:
.golangci.yml.Examples:
powerplatform_tenant_isolation_policyresource inexamples/resources/powerplatform_tenant_isolation_policy/resource.tfandexamples/tenant-isolation/main.tf. [1] [2]