powerplatform_data_record: added meaningful error when record already exist and HTTP 405 is returned #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawasile
requested review from
mattdot,
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
mattdot
approved these changes
Mar 5, 2025
…412-when-creating-app-user
…412-when-creating-app-user
mawasile
deleted the
mawasile/614-powerplatform_data_record-http-412-when-creating-app-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
internal/services/data_record/api_data_record.goandinternal/services/environment/resource_environment.gofiles to improve the handling of data records and environment resources. The most important changes include adding comments to clarify the logic for determining the HTTP method, handling thehttp.StatusPreconditionFailedstatus, and removing an unnecessary blank line.Improvements to data record handling:
internal/services/data_record/api_data_record.go: Added comments to clarify the logic for choosing betweenPOSTandPATCHmethods based on the presence of primary ID attributes in the columns or record ID.internal/services/data_record/api_data_record.go: Modified theExecutemethod call to handlehttp.StatusPreconditionFailedby attempting an update with thePATCHmethod and providing an error message if the primary ID is not included.Code cleanup:
internal/services/environment/resource_environment.go: Removed an unnecessary blank line to improve code readability.