Lifecycle operation will retry if 'Failed' status was return. #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… retry logic on failures
mawasile
added
bug
mawasile
requested review from
mattdot,
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
eduardodfmex
approved these changes
Mar 6, 2025
mattdot
approved these changes
Mar 6, 2025
…est-destroy-there-may-be-dangling-resources-exit-status-1
mawasile
deleted the
mawasile/620-panicgo629-error-running-post-test-destroy-there-may-be-dangling-resources-exit-status-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of lifecycle operations and retries in various API methods. The most important changes include adding retries for failed lifecycle operations, improving logging, and updating test cases to validate these changes.
Improvements to lifecycle operation handling:
internal/api/lifecycle.go: Updated logging messages and added handling for both "Succeeded" and "Failed" states in theDoWaitForLifecycleOperationStatusmethod.internal/services/enterprise_policy/api_enterprise_policy.go: Added retries for failed lifecycle operations in theLinkEnterprisePolicyandUnLinkEnterprisePolicymethods. [1] [2]internal/services/environment/api_environment.go: Added retries for failed lifecycle operations in theDeleteEnvironment,ModifyEnvironmentType,UpdateEnvironmentAiFeatures, andUpdateEnvironmentmethods. [1] [2] [3] [4]Test case updates:
internal/services/environment/resource_environment_test.go: Added a new test caseTestUnitEnvironmentsResource_Validate_Retry_LifecycleOperationto validate the retry logic for lifecycle operations.