[Feat] Detector implementation for Azure SAS Tokens #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used background context for individual test.
rgmz
reviewed
Mar 8, 2025
| ` | ||
| ) | ||
|
|
||
| func TestAzureSASToken_Pattern(t *testing.T) { |
There was a problem hiding this comment.
IMO this needs more positive and negative test cases. SAS tokens can be long and complicated, a single test isn't sufficient.
There was a problem hiding this comment.
Added more test cases to increase the coverage.
rgmz
reviewed
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements a new Detector for Azure SAS Token. This detector looks for blob URL with signature, generated via portal, and verify the credentials based on generated values. Please note that, The Detector type was already mentioned with the implementation. This PR reuse that type from proto
Test Output:
Checklist:
make test-community)?make lintthis requires golangci-lint)?