-
Notifications
You must be signed in to change notification settings - Fork 4k
Proxy Agent support for Gallery #27987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the Metadata Security Protocol (MSP) in Azure Compute Gallery by introducing new cmdlets to manage In-VM Access Control Profiles and their versions, along with corresponding help content, formatting, exports, changelog entries, and tests.
- Added help files for Create/Get/Update/Remove operations on In-VM Access Control Profiles and Versions, plus rule-level cmdlets (privileges, roles, identities, role assignments).
- Updated the module manifest (
Az.Compute.psd1
) to export the new cmdlets. - Extended output formatting (
Compute.format.ps1xml
), updatedChangeLog.md
, and added scenario tests (GalleryTests.ps1
andGalleryTests.cs
).
Reviewed Changes
Copilot reviewed 22 out of 46 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/Compute/Compute/help/Update-AzGalleryInVMAccessControlProfileVersion.md | Help for updating a profile version |
src/Compute/Compute/help/Update-AzGalleryInVMAccessControlProfile.md | Help for updating a profile |
src/Compute/Compute/help/Remove-AzGalleryInVMAccessControlProfileVersionRulesRoleAssignment.md | Help for removing a role assignment |
src/Compute/Compute/help/Remove-AzGalleryInVMAccessControlProfileVersionRulesRole.md | Help for removing a role |
src/Compute/Compute/help/Remove-AzGalleryInVMAccessControlProfileVersionRulesPrivilege.md | Help for removing a privilege |
src/Compute/Compute/help/Remove-AzGalleryInVMAccessControlProfileVersionRulesIdentity.md | Help for removing an identity |
src/Compute/Compute/help/Remove-AzGalleryInVMAccessControlProfileVersion.md | Help for removing a profile version |
src/Compute/Compute/help/Remove-AzGalleryInVMAccessControlProfile.md | Help for removing a profile |
src/Compute/Compute/help/New-AzGalleryInVMAccessControlProfileVersionConfig.md | Help for creating a local version config |
src/Compute/Compute/help/New-AzGalleryInVMAccessControlProfileVersion.md | Help for creating a profile version |
src/Compute/Compute/help/New-AzGalleryInVMAccessControlProfile.md | Help for creating a profile |
src/Compute/Compute/help/Get-AzGalleryInVMAccessControlProfileVersion.md | Help for retrieving a profile version |
src/Compute/Compute/help/Get-AzGalleryInVMAccessControlProfile.md | Help for retrieving a profile |
src/Compute/Compute/help/Add-AzGalleryInVMAccessControlProfileVersionRulesRoleAssignment.md | Help for adding a role assignment |
src/Compute/Compute/help/Add-AzGalleryInVMAccessControlProfileVersionRulesRole.md | Help for adding a role |
src/Compute/Compute/help/Add-AzGalleryInVMAccessControlProfileVersionRulesPrivilege.md | Help for adding a privilege |
src/Compute/Compute/help/Add-AzGalleryInVMAccessControlProfileVersionRulesIdentity.md | Help for adding an identity |
src/Compute/Compute/Compute.format.ps1xml | Updated output formatting for new models |
src/Compute/Compute/ChangeLog.md | Added changelog entries for MSP support |
src/Compute/Compute/Az.Compute.psd1 | Exported new cmdlets in module manifest |
src/Compute/Compute.Test/ScenarioTests/GalleryTests.ps1 | Scenario tests for In-VM access control |
src/Compute/Compute.Test/ScenarioTests/GalleryTests.cs | C# acceptance test for profile versions |
Comments suppressed due to low confidence (4)
src/Compute/Compute/Az.Compute.psd1:208
- Normalize casing: change
Remove-AzGalleryInVmAccessControlProfileVersionRulesRole
toRemove-AzGalleryInVMAccessControlProfileVersionRulesRole
to match the other cmdlet names.
'Add-AzGalleryInVMAccessControlProfileVersionRulesRole', 'Remove-AzGalleryInVmAccessControlProfileVersionRulesRole',
src/Compute/Compute/help/New-AzGalleryInVMAccessControlProfileVersionConfig.md:17
- Parameter name mismatch: help syntax shows
-TargetLocation
but examples and later parameter block use-TargetLocations
. Align these names for consistency.
-DefaultAccess <String> -TargetLocation <String[]> [-ExcludeFromLatest]
src/Compute/Compute/help/Update-AzGalleryInVMAccessControlProfileVersion.md:31
- Example uses
-TargetRegion
but the syntax defines-TargetLocation
; update the example to use the correct parameter name.
Update-AzGalleryInVMAccessControlProfileVersion -GalleryInVmAccessControlProfileVersion $CPversion -TargetRegion @("West US 2", "West US") -ExcludeFromLatest $true
src/Compute/Compute/help/Update-AzGalleryInVMAccessControlProfileVersion.md:85
- Placeholder
{{ Fill ProgressAction Description }}
should be replaced with an actual description of the-ProgressAction
parameter.
{{ Fill ProgressAction Description }}
Hi @grizzlytheodore, please update the PR title to a meaningful one. |
Done ! |
requesting OOB release for this along with |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.