[SampleApp] GitHub icon not centered (NIT) #4489
Description
Describe the bug
The GitHub icon is not centered inside the button. While this is not visible on its own, when hovering over the icon, the imbalance is visible:
Regression
No response
Reproducible in sample app?
- This bug can be reproduced in the sample app.
Steps to reproduce
1. Checkout CommunityToolkit repository
1. Build and launch Sample app
1. Navigate to any sample
Expected behavior
The icon should be centered.
Screenshots
No response
Windows Build Number
- Windows 10 1809 (Build 17763)Windows 10 1903 (Build 18362)Windows 10 1909 (Build 18363)Windows 10 2004 (Build 19041)Windows 10 20H2 (Build 19042)Windows 10 21H1 (Build 19043)Windows 11 21H2 (Build 22000)Other (specify)
Other Windows Build number
Windows 10 Insider Build 19044
App minimum and target SDK version
- Windows 10, version 1809 (Build 17763)Windows 10, version 1903 (Build 18362)Windows 10, version 1909 (Build 18363)Windows 10, version 2004 (Build 19041)Other (specify)
Other SDK version
No response
Visual Studio Version
2022
Visual Studio Build Number
No response
Device form factor
Desktop
Nuget packages
No response
Additional context
No response
Help us help you
Yes, I'd like to be assigned to work on this item.
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Participants
Activity
ghost commentedon Feb 16, 2022
Hello chingucoding, thank you for opening an issue with us!
I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌
michael-hawker commentedon Feb 17, 2022
Thanks @chingucoding! I may be pushing an update out to the sample app soon for the DataGrid issue, so if you'd like to submit a PR, feel free.
Otherwise, as you know from our #4486 memo, we'll be redoing a lot of the infrastructure and that should replace our current sample app. Happy to have your input and advice as we move forward in those directions. Hopefully we'll be ready in the next week or so to invite any of our longstanding community collaborators to help provide feedback and test things out before we make our new Labs repo public.
marcelwgn commentedon Feb 17, 2022
Sure thing. If you think it would be better to wait the infrastructure rethinking and Toolkit Labs, I would also be more than happy to wait for that. Let me know what you think!
michael-hawker commentedon Feb 17, 2022
@chingucoding if you think it'll just take you 10 minutes and you want to get a quick fix in, then happy to do it now for the patch of the sample app. But since it's a minor nit, I'm fine if we just leave it for now too. 😋
marcelwgn commentedon Feb 17, 2022
Yeah it shouldn't take too much time to fix, I'll get right to it.