Skip to content

Prep for JSON translation of Markdoc #30153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

jhgilbert
Copy link
Contributor

@jhgilbert jhgilbert commented Jun 26, 2025

What does this PR do? What is the motivation?

DOCSENG-3

  • Bump the Cdocs version to one that supports automatically creating *.ast.json files (see the Cdocs integration changelog for the list of differences between this version and the former version)
  • Ignore *.ast.json files, which are for translation purposes and do not need to be in version control
  • Add *.ast.json files to the list of files processed by Transifex

✅ This PR has passed the relevant Cdocs QA.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@jhgilbert jhgilbert requested a review from a team as a code owner June 26, 2025 18:03
Copy link
Contributor

github-actions bot commented Jun 26, 2025

ℹ️ Documentation Team Review

No documentation team review is required for this pull request.

@jhgilbert jhgilbert added the WORK IN PROGRESS No review needed, it's a wip ;) label Jul 1, 2025
@jhgilbert jhgilbert requested a review from a team as a code owner July 1, 2025 21:48
@jhgilbert jhgilbert changed the title Prep for JSON translation Prep for JSON translation of Markdoc Jul 2, 2025
@jhgilbert jhgilbert removed the WORK IN PROGRESS No review needed, it's a wip ;) label Jul 2, 2025
@jhgilbert jhgilbert merged commit c3852f6 into master Jul 2, 2025
19 checks passed
@jhgilbert jhgilbert deleted the jen.gilbert/DOCSENG-3-markdoc-translation branch July 2, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants