Skip to content

Make some of the bundle commands Sorbet typed: true #20145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jun 20, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

- The last remaining one is `exec` but that's a bit more involved
  (#20128 (comment)).
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid enabled auto-merge June 20, 2025 10:57
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 20, 2025
Merged via the queue into master with commit d0a1445 Jun 20, 2025
33 checks passed
@MikeMcQuaid MikeMcQuaid deleted the some-bundle-files-werent-typed-at-all-but-now-some-are branch June 20, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants