Skip to content

download_strategy: fossil now outputs hash: #20150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

EricFromCanada
Copy link
Member

@EricFromCanada EricFromCanada commented Jun 21, 2025

URLs using :fossil checkouts haven't worked since fossil switched from printing uuid: to hash: for fossil info tip.

Also, fix this error for CVS checkouts:

$ brew fetch -s -v --HEAD mandoc
==> Cloning anoncvs@mandoc.bsd.lv:/cvs
/usr/bin/env PATH=/usr/bin:/opt/homebrew/opt/cvs/bin:/opt/homebrew/Library/Homebrew/shims/shared:/bin:/usr/sbin:/sbin cvs -d anoncvs@mandoc.bsd.lv:/cvs checkout -d /Users/eric/mandoc--cvs mandoc
Warning: Permanently added 'mandoc.bsd.lv' (ED25519) to the list of known hosts.
cvs [server aborted]: absolute pathname `/Users/eric/mandoc--cvs' illegal for server
Error: Failed to download resource "mandoc"
Failure while executing; `/usr/bin/env PATH=/usr/bin:/opt/homebrew/opt/cvs/bin:/opt/homebrew/Library/Homebrew/shims/shared:/bin:/usr/sbin:/sbin cvs -d anoncvs@mandoc.bsd.lv:/cvs checkout -d /Users/eric/mandoc--cvs mandoc` exited with 1. Here's the output:
Warning: Permanently added 'mandoc.bsd.lv' (ED25519) to the list of known hosts.
cvs [server aborted]: absolute pathname `/Users/eric/mandoc--cvs' illegal for server

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need/want backwards compatibility with older versions?

@EricFromCanada
Copy link
Member Author

EricFromCanada commented Jun 22, 2025

I doubt it; the current version's prebuilt binary (2.26) runs on 10.13+ and compiles from source on earlier versions, so I don't see any reason for 2.11 and earlier to still be out in the wild. But it's an easy fix so I added it anyway.

@EricFromCanada EricFromCanada force-pushed the download_strategy-fossil branch from 34c856d to 8a4cac0 Compare June 22, 2025 18:40
@EricFromCanada EricFromCanada enabled auto-merge June 22, 2025 18:42
@EricFromCanada EricFromCanada added this pull request to the merge queue Jun 23, 2025
Merged via the queue into master with commit 2703f12 Jun 23, 2025
52 of 53 checks passed
@EricFromCanada EricFromCanada deleted the download_strategy-fossil branch June 23, 2025 03:16
@MikeMcQuaid
Copy link
Member

Thanks @EricFromCanada!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants