Skip to content

updating json with cask/migrator #20168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

tyuwags
Copy link
Contributor

@tyuwags tyuwags commented Jun 24, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is not fixing entirely #19951
As seen in the issue, some casks are called through .rb file and not .json file. The problem is that the .rb doesn't contain an old_tokens field

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @tyuwags!

@MikeMcQuaid MikeMcQuaid enabled auto-merge June 25, 2025 07:54
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 25, 2025
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Jun 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 25, 2025
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 25, 2025
Merged via the queue into Homebrew:main with commit 9fa50e5 Jun 25, 2025
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants