Skip to content

download_strategy: Add logging when a cached download is being ignored #20169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

boblail
Copy link
Contributor

@boblail boblail commented Jun 24, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon re-review: I think this is fine for now. Thanks @boblail!

@MikeMcQuaid MikeMcQuaid force-pushed the lail/invalidate-download-cache-logging branch from 105df03 to 048f581 Compare June 25, 2025 07:32
@MikeMcQuaid MikeMcQuaid enabled auto-merge June 25, 2025 07:32
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 25, 2025
Merged via the queue into Homebrew:main with commit ca510da Jun 25, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants