[gdb] Better handle typedefs to anonymous unions #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketj
approved these changes
Aug 20, 2019
server/JsDbg.Gdb/JsDbg.py
Outdated
| # The type may be a typedef to an anonymous union (e.g. | ||
| # base::internal::LockImpl::NativeHandle). In that case, keep the | ||
| # typedef name so we have *some* name to refer to this type. | ||
| # (This is only and issue with clang, |
When compiled with clang, for a typedef to an anonymous union, gdb will not be able to find a name and so 'name' is None. When that happens, we should just not call strip_typedefs to keep a name to refer to the type. Because this only happens with clang, I have not written a testcase for this bug. I did file a clang bug (see link in comment). This shows up with base::internal::LockImpl::NativeHandle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiled with clang, for a typedef to an anonymous union, gdb
will not be able to find a name and so 'name' is None. When that
happens, we should just not call strip_typedefs to keep a name
to refer to the type.
Because this only happens with clang, I have not written a testcase
for this bug. I did file a clang bug (see link in comment).
This shows up with base::internal::LockImpl::NativeHandle.