-
Notifications
You must be signed in to change notification settings - Fork 183
Bump oclif/core to version 4.4.0 #6041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
31f0eb4
to
41fa265
Compare
/snapit |
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/cli@0.0.0-snapshot-20250702104341 Tip If you get an Caution After installing, validate the version by running just |
41fa265
to
768cb6c
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success2916 tests passing in 1262 suites. Report generated by 🧪jest coverage report action from 768cb6c |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -1,5 +1,7 @@
import { Command } from '@oclif/core';
-import { FlagOutput, Input, ParserOutput, FlagInput, ArgOutput } from '@oclif/core/lib/interfaces/parser.js';
+import { OutputFlags, Input, ParserOutput, FlagInput, OutputArgs } from '@oclif/core/parser';
+export type ArgOutput = OutputArgs<any>;
+export type FlagOutput = OutputFlags<any>;
declare abstract class BaseCommand extends Command {
static baseFlags: FlagInput<{}>;
static descriptionWithoutMarkdown(): string | undefined;
@@ -8,7 +10,7 @@ declare abstract class BaseCommand extends Command {
catch(error: Error & {
skipOclifErrorHandling: boolean;
}): Promise<void>;
- protected init(): Promise<any>;
+ protected init(): Promise<unknown>;
protected showNpmFlagWarning(): void;
protected exitWithTimestampWhenEnvVariablePresent(): void;
protected parse<TFlags extends FlagOutput & {
packages/cli-kit/dist/public/node/cli.d.ts@@ -29,11 +29,11 @@ export declare function runCreateCLI(options: RunCLIOptions, launchCLI?: (option
* are shared across all the commands.
*/
export declare const globalFlags: {
- 'no-color': import("@oclif/core/lib/interfaces/parser.js").BooleanFlag<boolean>;
- verbose: import("@oclif/core/lib/interfaces/parser.js").BooleanFlag<boolean>;
+ 'no-color': import("@oclif/core/interfaces").BooleanFlag<boolean>;
+ verbose: import("@oclif/core/interfaces").BooleanFlag<boolean>;
};
export declare const jsonFlag: {
- json: import("@oclif/core/lib/interfaces/parser.js").BooleanFlag<boolean>;
+ json: import("@oclif/core/interfaces").BooleanFlag<boolean>;
};
/**
* Clear the CLI cache, used to store some API responses and handle notifications status
packages/cli-kit/dist/public/node/custom-oclif-loader.d.ts@@ -1,5 +1,5 @@
import { Command, Config } from '@oclif/core';
-import { Options } from '@oclif/core/lib/interfaces/plugin.js';
+import { Options } from '@oclif/core/interfaces';
export declare class ShopifyConfig extends Config {
constructor(options: Options);
customPriority(commands: Command.Loadable[]): Command.Loadable | undefined;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
WHY are these changes introduced?
To update the oclif dependency from 4.11.3 to 4.20.1 and @oclif/core from 3.26.5 to 4.4.0 across the codebase.
WHAT is this pull request doing?
...
)How to test your changes?
pnpm install
to update dependenciesMeasuring impact
How do we know this change was effective? Please choose one:
Checklist