fix: make dev store creation links clickable in CLI #6043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success2916 tests passing in 1262 suites. Report generated by 🧪jest coverage report action from 478adc7 |
- Changed getCreateDevStoreLink() to return TokenItem instead of string - Updated both app-management-client and partners-client implementations - Links now use CLI UI Kit's clickable link format Fixes #114 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
amcaplan
force-pushed
the
clickable-link-fix
branch
from
90627e8 to
58a1e8c
Compare
This comment has been minimized.
This comment has been minimized.
amcaplan
commented
Jul 2, 2025
- Changed link labels from URLs to 'Create one now' - Removed duplicate text from messages to avoid repetition - Improves user experience with clearer action text Addresses reviewer feedback on PR #6043
- Removed newline character between message and link - Link now appears on the same line as the message - Fixes spacing issue identified in PR review
|
amcaplan
changed the title
isaacroldan
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the dev store creation URL clickable in the CLI when developers don't have any dev stores associated with their organization.
What changed
getCreateDevStoreLink()in bothapp-management-client.tsandpartners-client.tsto returnTokenIteminstead of plain stringDeveloperPlatformClientinterface to reflect the new return type{link: {url, label}}Why
Previously, developers had to manually copy and paste the URL from the terminal. With this change, they can click the link directly in terminals that support clickable links, improving the developer experience.
Test plan
npm devwithout any dev stores to see the clickable linkFixes https://github.com/shop/issues-develop/issues/114