Add app information modal to dev session UI #6052
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success2927 tests passing in 1264 suites. Report generated by 🧪jest coverage report action from 060cc88 |
- Add appURL prop to DevSessionUI component interface - Display App URL in terminal footer when available - Pass development URL from config through renderDev to DevSessionUI - Show App URL above Preview URL and GraphiQL URL for consistent ordering 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit introduces a comprehensive app information modal accessible via the 'i' key during `shopify app dev` sessions. The modal displays essential app details including app name, app URL, config file, dev store, and organization in a clean, formatted interface. Key features: - Modal triggered by 'i' key (when app preview is ready) - Escape key or 'i' key again to close - Uses Alert component from cli-kit for consistent styling - Hides preview/GraphiQL URLs when modal is active - Comprehensive test coverage with 21 test cases - Follows existing code patterns and conventions Files changed: - DevSessionUI: Added modal state management and keyboard handlers - New utility: formatAppInfoBody for consistent formatting - Enhanced prop threading through dev session components - Updated test snapshots and added extensive test coverage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
The Box wrapper around the persistent dev alert was inadvertently removed.
This change restores the proper spacing and layout consistency by adding
back the Box component with marginTop={1} and flexDirection="column".
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
nickwesselman
force-pushed
the
feature/app-info-modal
branch
from
5a49f25 to
913b4b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new
app devcommand makes the app URL less accessible. This PR adds a newApp Informationmodal accessible via theikey inapp dev, which includes the app URL. It also adds the App URL as an output to theapp devlogs, via dev session messaging on the app home component.Key Features
• Modal triggered by 'i' key - Only available when app preview is ready
• Escape key or 'i' again to close - Intuitive toggle behavior
• Comprehensive app information display:
• Clean UI integration - Hides preview/GraphiQL URLs when modal is active
• Consistent styling - Uses Alert component from cli-kit for proper formatting
Implementation Details
formatAppInfoBodyutility following existing patternsTesting
Code Quality
Test plan
shopify app devcommand🤖 Generated with Claude Code