fix(core): prevent setState crashing when used directly #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fix resolves a bug introduced in 06c8227 which converted
setState
from an arrow function to a standard function. The change meant that thethis
context was no longer bound to the store, and would cause the function to crash when called directlyconst setState = store.setState
.Since this change was necessary for function definition overloading in typescript, This PR bounds the function to the store in the constructor and adds test cases for this scenario