Remove deployment-target to avoid conflicts with project / other plugins

[jfougere]

I propose to remove the deployment-target set to 12 in the plugin.xml file in order to avoid conflicts with other plugin or project during the add platform.

Having this set here will potentially create duplicated preference being set by cordova in the config.xml created inside the platform folder. Also it affects the version set in the Podfile which in turns may break the installation of other plugin requiring a higher baseline

[uerceg]

Hey @jfougere,

Thank you for the PR. Having in mind that we are since some time ago pulling our native iOS SDK dependency via CocoaPods, I'd imagine that the fact that we are stating there that iOS 12 is the minimal deployment target, it should be handled properly in case someone decides to select the lower version for their iOS app.

Just out of curiosity:

Having this set here will potentially create duplicated preference being set by cordova in the config.xml created inside the platform folder. Also it affects the version set in the Podfile which in turns may break the installation of other plugin requiring a higher baseline

How does this issue manifest on your end? Do you see multiple

platform :ios, '12.0'
platform :ios, '12.0'
platform :ios, '13.0'

entries in your resulting Podfile or in some other way?

Anyway, we'll ship the patch update where we'll add your PR.

[uerceg]

Replaced with #199.

[jfougere]

Hi @uerceg in our projet the deployment target was set to 16 but having 12 set in your plugin had the following consequences:

• Duplicated deployment target in the config.xml which is reported in platform/ios/cordova
• The version in the podfile was set to 12 instead of 16 and so other plugin using cocoapods requiring a higher target would fail to install

[uerceg]

Thank you very much for the detailed description, I appreciate it.

And you probably have noticed it, but just for the record - we have shipped v5.4.1 which should contain this change. Feel free to give it a shot and in case something's still not working as it should or or you have any other questions, let us know.

Thank you one more time for you contribution.

Cheers.