Skip to content

Add trailer parsing logic #11269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add trailer parsing logic #11269

wants to merge 15 commits into from

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Jul 4, 2025

This adds trailer parsing to the parsing logic. First step towards #1652.

It does not yet expose the trailers, so there are no visible user changes, but paves the way for a future PR to add the public API to these.

@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner July 4, 2025 18:01
@Dreamsorcerer Dreamsorcerer requested review from bdraco and removed request for asvetlov July 4, 2025 18:01
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (c106c5b) to head (95c3088).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11269      +/-   ##
==========================================
- Coverage   98.84%   98.84%   -0.01%     
==========================================
  Files         131      131              
  Lines       43262    43258       -4     
  Branches     2327     2326       -1     
==========================================
- Hits        42761    42757       -4     
  Misses        346      346              
  Partials      155      155              
Flag Coverage Δ
CI-GHA 98.73% <100.00%> (-0.01%) ⬇️
OS-Linux 98.46% <100.00%> (-0.01%) ⬇️
OS-Windows 96.80% <98.14%> (-0.01%) ⬇️
OS-macOS 97.68% <98.14%> (-0.01%) ⬇️
Py-3.10.11 97.33% <98.14%> (+<0.01%) ⬆️
Py-3.10.18 97.82% <100.00%> (-0.01%) ⬇️
Py-3.11.13 98.00% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.52% <98.14%> (-0.01%) ⬇️
Py-3.12.10 97.62% <98.14%> (-0.01%) ⬇️
Py-3.12.11 98.11% <100.00%> (+<0.01%) ⬆️
Py-3.13.3 98.36% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.21% <98.14%> (-0.01%) ⬇️
Py-3.9.23 97.69% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 85.50% <98.14%> (-8.81%) ⬇️
VM-macos 97.68% <98.14%> (-0.01%) ⬇️
VM-ubuntu 98.46% <100.00%> (-0.01%) ⬇️
VM-windows 96.80% <98.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jul 4, 2025

CodSpeed Performance Report

Merging #11269 will not alter performance

Comparing add-trailer-parser (95c3088) with master (c106c5b)

Summary

✅ 59 untouched benchmarks

@Dreamsorcerer Dreamsorcerer requested a review from webknjaz as a code owner July 4, 2025 19:16
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 6, 2025
@Dreamsorcerer Dreamsorcerer added backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot and removed bot:chronographer:provided There is a change note present in this PR labels Jul 6, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 6, 2025
@Dreamsorcerer Dreamsorcerer changed the title Add trailer parsing Add trailer parsing logic Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant