feat(cdk/menu): add setActiveMenuItem to cdkMenu #31371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chintankavathia
requested review from
andrewseguin and
ok7sai
and removed request for
a team
angular-robot
bot
added
detected: feature
crisbeto
reviewed
Jun 24, 2025
| */ | ||
| setActiveMenuItem(item: number | CdkMenuItem) { | ||
| if (this.keyManager) { | ||
| if (typeof item === 'number') { |
There was a problem hiding this comment.
You don't need this check, the key manager does it automatically.
There was a problem hiding this comment.
Yes its not needed but typescript is not happy so I had to add.
There was a problem hiding this comment.
I see. Let's keep it as is and I'll clean it up later.
crisbeto
approved these changes
Jun 24, 2025
chintankavathia
force-pushed
the
fix/cdk/menu/focus
branch
from
4cc5a18 to
64535aa
Compare
chintankavathia
force-pushed
the
fix/cdk/menu/focus
branch
from
64535aa to
774d0a2
Compare
crisbeto
approved these changes
Jun 24, 2025
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 29, 2025
This is a follow-up to angular#31371 (comment). `ListKeyManager.setActiveItem` supports both a reference to an item or an index, however there's no override that allows `T | number` which can be inconvenient. These changes add extra overrides to resolve the issue.
crisbeto
added a commit
that referenced
this pull request
Jul 1, 2025
) This is a follow-up to #31371 (comment). `ListKeyManager.setActiveItem` supports both a reference to an item or an index, however there's no override that allows `T | number` which can be inconvenient. These changes add extra overrides to resolve the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #31370 for more details