Floralph/nep flare #1638
Draft
Floralph/nep flare #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovider (#1188) * feat(client): add support for edit suggestions in inline completion provider * feat(client): update to use isInlineEdit and simplify telemetry * feat(client): improve comments and fix redundant code
- Add support for insertText property in server responses - Implement robust udiff handling with diff-match-patch library - Fix issue with lingering diff encoding in edit suggestions - Add detailed logging for better diagnostics - Handle edge cases in patch application
- Remove excessive logging - Keep only essential debug messages - Simplify code while maintaining functionality
- Add diff-match-patch and its type definitions - Document the need for robust udiff handling - Prepare for PR submission
feat: adding new fields for NEP telemetry event
fix: make new fields in userModificationEvent optional
…m main branch and fixed conflicts in multiple files.\nUpdated emitUserModificationEvent call to match new API signature
Merged latest changes from main branch and fixed conflicts in multiple files. Updated emitUserModificationEvent call to match new API signature
Added .gitallowed file to prevent false positive detection of '.brazil' directory name in constants.ts
Updated .gitallowed to only allow '.brazil' in the constants.ts file for better security
Added auto-trigger files for NEP edit prediction feature
Populate telemetry metrics for NEP
pass addedCharacterCount and deletedCharacterCount to UTG event
leigaol
reviewed
Jun 12, 2025
|
|
||
| # Workspace | ||
| client/vscode/lsp_client.code-workspace | ||
| package-lock.json |
There was a problem hiding this comment.
package-lock.json needs to be removed from here
leigaol
reviewed
Jun 12, 2025
| "args": [ | ||
| "--extensionDevelopmentPath=${workspaceFolder}/client/vscode", | ||
| "--disable-extensions", | ||
| "--enable-proposed-api=aws.awsdocuments-ls-client", |
There was a problem hiding this comment.
This proposed API cannot be used in production.
There was a problem hiding this comment.
it is OK to only use it in debug
leigaol
reviewed
Jun 12, 2025
| @@ -28,7 +32,7 @@ const props = createTokenRuntimeProps(VERSION, [ | |||
| BashToolsServer, | |||
| QLocalProjectContextServerTokenProxy, | |||
| WorkspaceContextServerTokenProxy, | |||
| // McpToolsServer, | |||
There was a problem hiding this comment.
this diff should not exist in this PR..
leigaol
reviewed
Jun 12, 2025
| @@ -1,17 +1,9 @@ | |||
| const path = require('path') | |||
| var path = require('path') | |||
| const webpack = require('webpack') | |||
| const HtmlWebpackPlugin = require('html-webpack-plugin') | |||
There was a problem hiding this comment.
please keep this file as is. There is a high chance that this breaks our release pipeline
leigaol
reviewed
Jun 12, 2025
| @@ -1,5 +1,30 @@ | |||
| # Changelog | |||
|
|
|||
| ## [0.1.15](https://github.com/aws/language-servers/compare/chat-client/v0.1.14...chat-client/v0.1.15) (2025-06-11) | |||
|
|
|||
There was a problem hiding this comment.
this diff should not be in this pr
feat: adding feature flag and merge codeWhispererServer.ts from main
fix: removing logic to skip suggestion at same location
fix: remove checking for predictionTypes in codeWhispererServer
Fix unit test failures due to NEP
fix: fix telemetry unit test
feat: adding logic to merge with previous suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.