-
Notifications
You must be signed in to change notification settings - Fork 73
feat: produce agentic chat bundle from repo #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# downloadable artifacts are nicely organized, one per platform. | ||
- name: Prepare and upload artifacts | ||
run: | | ||
platforms=("linux-arm64" "linux-x64" "mac-arm64" "mac-x64" "win-x64") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need Windows arm64. See https://aws-toolkit-language-servers.amazonaws.com/qAgenticChatServer/0/manifest.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're currently copying the win-x86 builds to win-arm late in the distribution pipeline. We should introduce support for this, but that should be a separate task on the backlog. My current goal is to port the existing behaviors into the repo, which can then be iterated on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the size limit of Github LFS? Can it suppport 10GB?
At development time, do we need to pull these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The largest file is 2gb, but I don't know the cumulative space we're allowed to take up. Ideally we would try to reduce our reliance on LFS over time, but for now the goal is the ability to quickly produce builds.
We do not need these at development time, the intent is that the changes I'm adding are only used by CI jobs.
@@ -0,0 +1,94 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are using git lfs anyway, maybe we can also check in node binary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to avoid putting too much data in LFS, but then ended up adding the qserver files (500 mb). Unless there is a major concern, I'd prefer to download these for now, since our ideal state is to avoid using LFS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may need another script to automatically populate https://aws-language-servers.us-east-1.amazonaws.com/e37e261e-d046-460a-81ab-619b3c60f94a/THIRD_PARTY_LICENSES in https://aws-toolkit-language-servers.amazonaws.com/qAgenticChatServer/0/manifest.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I have a separate task to track that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe merge on Monday just in case this PR failed to build inside the internal pipeline
This change allows us to produce agentic chat artifacts directly from the repo. A new GitHub Action has been created that will build these artifacts for every commit made to the
main
andfeature/*
branches. The artifacts will be available (for a limited time) from the GitHub commit check.These changes were developed on an Ubuntu WSL image. There are bash scripts involved, which will not run on Windows. The intention is that these are run from a linux based CI compute.
To support this change:
ci:generate:agent-standalone
has been created in the workspaceapp/aws-lsp-codewhisperer-runtimes
. This is the command that CI compute will run to produce the artifacts.Upcoming changes will make use of this one in order to make agentic chat builds easier to obtain.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.