fix(firefox): font might be undefined

[QuentiumYT]

Description

Fix an issue on Firefox only where sometimes the font can be undefined after split.

Motivation and Context

It breaks the whole screenshot process and fails to download in Firefox because of undefined font.

const fontFamily = node.style.fontFamily || getComputedStyle(node).fontFamily;
console.log("----", fontFamily, typeof fontFamily);

AND

console.log(font, typeof font);
return font.trim().replace(/["']/g, '');

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Enhancement (changes that improvement of current feature or performance)
• Refactoring (changes that neither fixes a bug nor adds a feature)
• Test Case (changes that add missing tests or correct existing tests)
• Code style optimization (changes that do not affect the meaning of the code)
• Docs (changes that only update documentation)
• Chore (changes that don't modify src or test files)

Self Check before Merge

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[biiibooo]

👋 @QuentiumYT

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add graph.scale() method
• docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

• Follow the TypeScript coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.50%. Comparing base (d9b2fcf) to head (e7ac963).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files          10       10           
  Lines         612      612           
  Branches      150      150           
=======================================
  Hits          407      407           
  Misses        144      144           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[QuentiumYT]

Can you have a look at it @bubkoo, thanks :)

[ashutosh-aneja]

return font?.trim()?.replace(/["']/g, '')

[QuentiumYT]

Well I'm not sure if it's needed, only font could be undefined. Trim and replace will not throw errors I guess if it's an empty string

[ashutosh-aneja]

only undefined will throw exception, and there are the possibilities of font coming as undefined.

[QuentiumYT]

I see, I cannot edit my code right now, I hope the maintainer could add this silent fail for fonts in a separate commit then