refactor(tests): templating for p2 tests #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
refactor(tests)=test-templating
branch
2 times, most recently
from
7c466cc to
5dbe122
Compare
|
This now looks so much better. Thank you! |
vados-cosmonic
force-pushed
the
refactor(tests)=test-templating
branch
9 times, most recently
from
53a9d72 to
535b91b
Compare
vados-cosmonic
force-pushed
the
refactor(tests)=test-templating
branch
6 times, most recently
from
f33c109 to
511fa5a
Compare
vados-cosmonic
commented
Jun 16, 2025
vados-cosmonic
commented
Jun 16, 2025
vados-cosmonic
force-pushed
the
refactor(tests)=test-templating
branch
from
bc90a2f to
a2e76a0
Compare
vados-cosmonic
commented
Jun 16, 2025
vados-cosmonic
commented
Jun 16, 2025
vados-cosmonic
commented
Jun 16, 2025
vados-cosmonic
commented
Jun 16, 2025
vados-cosmonic
force-pushed
the
refactor(tests)=test-templating
branch
3 times, most recently
from
9b5d5cc to
cd40236
Compare
vados-cosmonic
force-pushed
the
refactor(tests)=test-templating
branch
7 times, most recently
from
15f9bb2 to
2648d44
Compare
|
Note: test generation was moved into particular platform CI test jobs because the paths in generated tests (after the changes in this PR) were absolute and not platform-independent. The idea was that it's better to have absolute paths in most places than relative ones that can make tests brittle, and since generating tests is much faster now (~10s -> ~2s), we can "just" generate them right before use on the appropriate platform. |
vados-cosmonic
force-pushed
the
refactor(tests)=test-templating
branch
4 times, most recently
from
959c6b5 to
028f973
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
refactor(tests)=test-templating
branch
2 times, most recently
from
a762d6e to
3810eec
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
refactor(tests)=test-templating
branch
from
3810eec to
f18b4f1
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few changes in this PR, including:
Running the generation has gone from ~10 seconds to ~2 in local testing, and we've removed the dep on
wasm-toolsin the environment (not sure why it was there, given we have access towit-component)