fix(p3-shim): avoid flakiness in http test #761
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP tests seem to cause some flakiness, so let's randomize the ports to avoid collisions first.
Likely the fix will be to add retries to the specific test that's failing, but since there's no obvious source, this refactor reduces the likelihood and if the flakes reappear we can drill down to the relevant test and add retries in case network is flaky (though localhost really should not be).