feat(ci): run clippy on codebase

[andreiltd]

What is says on the tin, let's make clippy happy.

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[vados-cosmonic]

Thanks for adding clippy-- in the past clippy was avoided in jco because to other maintainers it seemed like not a good use of time.

That said I'm happy to have clippy be part of the linting, however can we remove the SARIF stuff and keep code scanning disabled? That's worth discussing in it's own issue before we make the change to the codebase -- I don't think it provides much benefit if we're gating on clippy to begin with.

At present this PR is titled as if it's adding clippy but it's doing much more.

[andreiltd]

At present this PR is titled as if it's adding clippy but it's doing much more.

Do you mean fixing the clippy issues in the code or adding SARIF?

[vados-cosmonic]

Adding SARIF and turning on GH Code scanning -- having clippy check and fail is certainly useful for the same reason we check the JS but the other things are a little less clear.