Skip to content

Turn warnings into errors in CI #4397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Turn warnings into errors in CI #4397

wants to merge 3 commits into from

Conversation

lum1n0us
Copy link
Collaborator

  • Apply global warnings in config_common.cmake instead of maintaining them in separate files.
  • Enable errors during CI when building iwasm and wamrc

@lum1n0us lum1n0us linked an issue Jun 20, 2025 that may be closed by this pull request
Enables errors for implicit function declaration by default #4317
Open
@lum1n0us lum1n0us force-pushed the fix/global_wanring_options branch 3 times, most recently from 5275aca to 7493efa Compare June 20, 2025 07:52
lum1n0us added 2 commits June 24, 2025 12:47
@lum1n0us
Turn warnings into errors in CI
64c53a0 
- Apply global warnings in config_common.cmake instead of maintaining them
  in separate files.
- Enable errors during CI when building iwasm and wamrc
@lum1n0us
fix few shadow warnings
10613f4 
- declaration of ‘memidx’ shadows a previous local
-  declaration of ‘count’ shadows a previous local
@lum1n0us lum1n0us force-pushed the fix/global_wanring_options branch from a07b52a to 213ffdc Compare June 24, 2025 12:50
@lum1n0us lum1n0us force-pushed the fix/global_wanring_options branch from 213ffdc to 9891bec Compare June 24, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganek loganek Awaiting requested review from loganek loganek will be requested when the pull request is marked ready for review loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi will be requested when the pull request is marked ready for review no1wudi is a code owner

@TianlongLiang TianlongLiang Awaiting requested review from TianlongLiang TianlongLiang will be requested when the pull request is marked ready for review TianlongLiang is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh will be requested when the pull request is marked ready for review wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 will be requested when the pull request is marked ready for review xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt will be requested when the pull request is marked ready for review yamt is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enables errors for implicit function declaration by default
1 participant
@lum1n0us