Small enhancement copy_callstack feature #4401
Merged
+27
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `WAMR_ENABLE_COPY_CALLSTACK` to `WAMR_BUILD_COPY_CALL_STACK`, as `WAMR_BUILD` is the prefix for a command line option. - Change `WAMR_ENABLE_COPY_CALLSTACK` to `WASM_ENABLE_COPY_CALL_STACK`, as `WASM_ENABLE` is the prefix for a macro in the source code. - Change `CALLSTACK` to `CALL_STACK` to align with the existing `DUMP_CALL_STACK` feature. - Continue using `WASMCApiFrame` instead of `wasm_frame_t` outside of *wasm_c_api.xxx* to avoid a typedef redefinition warning, which is identified by Clang.
lum1n0us
requested review from
loganek,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
lum1n0us
changed the title
TianlongLiang
approved these changes
Jun 23, 2025
yamt
approved these changes
Jun 23, 2025
|
@g0djan Please be aware of it. |
|
thanks, seems okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAMR_ENABLE_COPY_CALLSTACKtoWAMR_BUILD_COPY_CALL_STACK, asWAMR_BUILDis the prefix for a command line option.WAMR_ENABLE_COPY_CALLSTACKtoWASM_ENABLE_COPY_CALL_STACK, asWASM_ENABLEis the prefix for a macro in the source code.CALLSTACKtoCALL_STACKto align with the existingDUMP_CALL_STACKfeature.WASMCApiFrameinstead ofwasm_frame_toutside of wasm_c_api.xxx to avoid a typedef redefinition warning, which is identified by Clang.