x64: Migrate push/pop to the new assembler #10977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Figured these would be some interesting instruction shapes. This adds a helper to the ISLE generation to skip some instructions and the "push" instructions are skipped as they're not needed in ISLE and would otherwise require binding new instruction shapes which didn't seem worth it. Additionally many items in `gen_asm.rs` were made private (removed `pub`).
github-actions
bot
added
cranelift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured these would be some interesting instruction shapes. This adds a
helper to the ISLE generation to skip some instructions and the "push"
instructions are skipped as they're not needed in ISLE and would
otherwise require binding new instruction shapes which didn't seem worth
it. Additionally many items in
gen_asm.rswere made private (removedpub).