Skip to content

x64: Match capstone disassembling callq 5 #11154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

alexcrichton
Copy link
Member

Apparently Capstone doesn't print a hexadecimal number for targets between 0 and 10. Unclear, but match it to prevent the fuzzer from tripping over this.

Apparently Capstone doesn't print a hexadecimal number for targets
between 0 and 10. Unclear, but match it to prevent the fuzzer from
tripping over this.
@alexcrichton alexcrichton requested a review from a team as a code owner June 27, 2025 22:47
@alexcrichton alexcrichton requested review from cfallin and removed request for a team June 27, 2025 22:47
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear -- good catch. (I have half a mind to go submit a PR to Capstone instead to remove this "helpful" heuristic...)

@cfallin cfallin added this pull request to the merge queue Jun 27, 2025
Merged via the queue into bytecodealliance:main with commit 2b3c74e Jun 27, 2025
42 checks passed
@alexcrichton alexcrichton deleted the x64-fix-call-print branch June 27, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants