Simplify some conditional testing logic for Winch #11166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run all tests on all platforms in `#[wasmtime_test]` for Winch without `#[cfg]` and use the result of `should_fail` to determine whether it should fail or not (e.g. still expect failure on riscv64/s390x/etc).
alexcrichton
force-pushed
the
refactor-winch-testing
branch
from
b735c6b to
246d574
Compare
alexcrichton
changed the title
|
Oops, sorry there was a wrong commit history which meant the PR description/OP didn't get filled out correctly and I missed that |
dicej
approved these changes
Jun 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run all tests on all platforms in
#[wasmtime_test]for Winch without#[cfg]and use the result ofshould_failto determine whether itshould fail or not (e.g. still expect failure on riscv64/s390x/etc).