Move the object size out of the reserved bits in the DRC collector #11169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to use those bits for other things as we implement bytecodealliance#11162. This also lets us increase the largest supported GC allocation to a full u32::MAX bytes.
alexcrichton
approved these changes
Jul 1, 2025
| ) | ||
| ) | ||
|
|
||
| (assert_trap (invoke "f") "allocation size too large") |
There was a problem hiding this comment.
Is it worth adapting this test to the new limit of 32-bits?
There was a problem hiding this comment.
tests/misc_testsuite/gc/array-alloc-too-large.wast already tests the 32-bit limit, so I think we are good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to use those bits for other things as we implement #11162.
This also lets us increase the largest supported GC allocation to a full
u32::MAXbytes.