Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-cordova
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: cloudscapelabs/sentry-cordova
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: csl
Choose a head ref
  • 13 commits
  • 10 files changed
  • 2 contributors

Commits on Sep 20, 2022

  1. Verified

    This commit was signed with the committer’s verified signature.
    kbrownlees-csl Kieran Brownlees
    Copy the full SHA
    ffa98bc View commit details
  2. Verified

    This commit was signed with the committer’s verified signature.
    kbrownlees-csl Kieran Brownlees
    Copy the full SHA
    24cfd5d View commit details
  3. Verified

    This commit was signed with the committer’s verified signature.
    kbrownlees-csl Kieran Brownlees
    Copy the full SHA
    77fccbb View commit details
  4. Verified

    This commit was signed with the committer’s verified signature.
    kbrownlees-csl Kieran Brownlees
    Copy the full SHA
    8f571a7 View commit details
  5. Verified

    This commit was signed with the committer’s verified signature.
    kbrownlees-csl Kieran Brownlees
    Copy the full SHA
    1dbfbc0 View commit details

Commits on Sep 6, 2023

  1. Verified

    This commit was signed with the committer’s verified signature.
    kbrownlees-csl Kieran Brownlees
    Copy the full SHA
    9295a71 View commit details

Commits on May 8, 2024

  1. Verified

    This commit was signed with the committer’s verified signature.
    kbrownlees-csl Kieran Brownlees
    Copy the full SHA
    2978f3b View commit details

Commits on May 9, 2024

  1. Verified

    This commit was signed with the committer’s verified signature.
    kbrownlees-csl Kieran Brownlees
    Copy the full SHA
    634cf81 View commit details

Commits on Sep 6, 2024

  1. Copy the full SHA
    9c94313 View commit details

Commits on Sep 8, 2024

  1. 1.3.0-csl3

    josh-cloudscape committed Sep 8, 2024
    Copy the full SHA
    e2a0c48 View commit details

Commits on Sep 9, 2024

  1. Copy the full SHA
    f78d48b View commit details
  2. Copy the full SHA
    a96c07d View commit details
  3. release: 1.3.0-csl4

    josh-cloudscape committed Sep 9, 2024
    Copy the full SHA
    358a065 View commit details
Showing with 2,702 additions and 3,249 deletions.
  1. +3 −0 .gitignore
  2. +1 −0 .npmrc
  3. +18 −0 README-CSL.md
  4. +24 −14 package.json
  5. +0 −5 plugin.xml
  6. +5 −5 scripts/before_compile.js
  7. +1 −3 scripts/plugin_add_rm.js
  8. +1 −1 src/js/scope.ts
  9. +3 −3 src/js/wrapper.ts
  10. +2,646 −3,218 yarn.lock
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -73,3 +73,6 @@ package-lock.json

# Generated Lockfiles
Cartfile.resolved

# CSL
*.iml
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
@cloudscapelabs:registry=https://npm.pkg.github.com
18 changes: 18 additions & 0 deletions README-CSL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
Install carthage: brew install carthage

Ensure master is up-to-date with upstream.

Merge in latest master (fixing conflicts in package name / version);

`git merge master`

`npm install`

Clean up the previous build:

`rm -rf dist`
`git clean -dfX src`

Then make a new build

`npm run build`
38 changes: 24 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
{
"name": "sentry-cordova",
"version": "1.3.0",
"name": "@cloudscapelabs/sentry-cordova",
"version": "1.3.0-csl4",
"main": "dist/js/sentry-cordova.js",
"types": "dist/js/sentry-cordova.d.ts",
"license": "MIT",
"repository": "git://github.com/getsentry/sentry-cordova.git",
"repository": "git://github.com/cloudscapelabs/sentry-cordova.git",
"publishConfig": {
"registry": "https://npm.pkg.github.com/"
},
"cordova": {
"id": "sentry-cordova",
"platforms": [
@@ -29,34 +32,41 @@
"@sentry/hub": "7.34.0",
"@sentry/types": "7.34.0",
"@sentry/utils": "7.34.0",
"@sentry/wizard": "^3.21.0"
"@sentry/wizard": "^3.28.0"
},
"devDependencies": {
"@sentry-internal/eslint-config-sdk": "7.34.0",
"@sentry-internal/typescript": "7.34.0",
"@sentry-internal/eslint-config-sdk": "^8.28.0",
"@sentry-internal/typescript": "^8.28.0",
"@types/cordova": "0.0.34",
"@types/jest": "^24.0.18",
"@types/jest": "^29.5.12",
"@types/node": "^12.7.5",
"codecov": "^3.5.0",
"eslint": "7.6.0",
"jest": "^24.9.0",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
"npm-run-all": "^4.1.5",
"prettier": "^1.18.2",
"prettier-check": "^2.0.0",
"replace-in-file": "^4.1.3",
"rimraf": "^3.0.0",
"rollup": "^1.10.1",
"rollup": "^2.79.1",
"rollup-plugin-commonjs": "^9.3.4",
"rollup-plugin-node-resolve": "^4.2.3",
"rollup-plugin-terser": "^4.0.4",
"rollup-plugin-typescript2": "^0.21.0",
"ts-jest": "^24.1.0",
"typescript": "^3.6.3"
"rollup-plugin-terser": "^7.0.2",
"rollup-plugin-typescript2": "^0.36.0",
"ts-jest": "^29.2.5",
"typescript": "^4.9.5"
},
"overrides": {
"@sentry/wizard": {
"axios": "^1.0.0"
}
},
"scripts": {
"build:bundle": "rollup --config",
"build:typescript": "tsc -p tsconfig.build.json",
"build": "run-s clean build:typescript build:bundle",
"build:ios": "make build",
"build": "run-s clean build:typescript build:bundle build:ios",
"clean": "rimraf dist coverage",
"jest": "jest",
"test:watch": "jest --watch",
5 changes: 0 additions & 5 deletions plugin.xml
Original file line number Diff line number Diff line change
@@ -35,11 +35,6 @@
</feature>
</config-file>

<config-file target="AndroidManifest.xml" parent="/manifest/application">
<meta-data android:name="io.sentry.auto-init" android:value="false" />
</config-file>


<source-file src="src/android/io/sentry/SentryCordova.java" target-dir="src/io/sentry/" />

<framework src="io.sentry:sentry-android:$SENTRY_ANDROID_SDK_VERSION" />
10 changes: 5 additions & 5 deletions scripts/before_compile.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
module.exports = function (ctx) {
console.log(`Sentry: running ${ctx.hook} - set SENTRY_SKIP_AUTO_RELEASE=true to skip this`);
if (process.env.SENTRY_RUN_AUTO_RELEASE !== 'true') {
console.log('Sentry: Skipping Sentry auto release');
return;
}

const SentryCli = require('@sentry/cli');
const path = require('path');
const fs = require('fs');
const crypto = require('crypto');

if (process.env.SENTRY_SKIP_AUTO_RELEASE) {
console.log('Sentry: Skipping Sentry auto release');
return;
}

function checksum(str) {
return crypto
4 changes: 1 addition & 3 deletions scripts/plugin_add_rm.js
Original file line number Diff line number Diff line change
@@ -5,9 +5,7 @@ module.exports = function (ctx) {
}
} catch (e) { }

console.log(`Sentry: running ${ctx.hook} - set SENTRY_SKIP_WIZARD=true to skip this`);

if (process.env.SENTRY_SKIP_WIZARD) {
if (process.env.SENTRY_RUN_WIZARD !== 'true') {
console.log('Sentry: Skipping Sentry Wizard');
return;
}
2 changes: 1 addition & 1 deletion src/js/scope.ts
Original file line number Diff line number Diff line change
@@ -29,7 +29,7 @@ export class CordovaScope extends Scope {
public setTags(tags: { [key: string]: string }): this {
// As native only has setTag, we just loop through each tag key.
Object.keys(tags).forEach(key => {
NATIVE.setTag(key, tags[key]);
NATIVE.setTag(key, tags[key]!);
});
return super.setTags(tags);
}
6 changes: 3 additions & 3 deletions src/js/wrapper.ts
Original file line number Diff line number Diff line change
@@ -86,7 +86,7 @@ export const NATIVE = {

const headerString = JSON.stringify(envelopeHeader);
let envelopeBytes: number[] = utf8ToBytes(headerString);
envelopeBytes.push(EOL);
envelopeBytes.push(EOL!);

for (const rawItem of envelopeItems) {

@@ -113,9 +113,9 @@ export const NATIVE = {
const serializedItemHeader = JSON.stringify(itemHeader);

envelopeBytes.push(...utf8ToBytes(serializedItemHeader));
envelopeBytes.push(EOL);
envelopeBytes.push(EOL!);
envelopeBytes = envelopeBytes.concat(bytesPayload);
envelopeBytes.push(EOL);
envelopeBytes.push(EOL!);
}
await this._nativeCall('captureEnvelope', { envelope: envelopeBytes });
},
5,864 changes: 2,646 additions & 3,218 deletions yarn.lock

Large diffs are not rendered by default.