fix: panic not triggered when all retries return ErrRPCFinish #1814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[What type of PR is this?](fix: panic not triggered when all retries return ErrRPCFinish)
Check the PR title.
(Optional) Translate the PR title into Chinese.
修复 MixedRetryer.Do 中所有重试请求返回 ErrRPCFinished 时未能触发 panic 的问题
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
This PR adds a test case to reproduce a rare panic scenario where all retry attempts in MixedRetryer.Do return ErrRPCFinished, leading to unexpected behavior (no panic triggered and nil response returned).
A fix is also provided to ensure proper panic is raised when all responses are ErrRPCFinished, maintaining consistency with the retry strategy design.
zh(optional):
本 PR 添加了一个测试用例,用于复现 MixedRetryer.Do 方法中所有重试请求都返回 ErrRPCFinished 时未能触发预期 panic 的问题。同时也修复了该逻辑,确保在这种极端场景下能够正确 panic,防止返回预期之外的err导致程序运行异常。
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: