Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

fix: Fix failure rate in public API #1302

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
Apparently, failure_rate was removed in a recent migration. This PR fetches the correct failure rate for users by dividing the number of failed runs by the total number of test runs.

Links to relevant tickets

codecov/engineering-team#3582

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link
Contributor

🚨 Sentry detected 5 potential issues in your recent changes 🚨

Lower risk findings

Did you find this useful? React with a 👍 or 👎

@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
api/public/v2/test_results/serializers.py 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.43%. Comparing base (bd7909a) to head (de2a6e7).

Files with missing lines Patch % Lines
api/public/v2/test_results/serializers.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    codecov/codecov-api#1302      +/-   ##
==========================================
- Coverage   96.43%   96.43%   -0.01%     
==========================================
  Files         488      488              
  Lines       16975    16982       +7     
==========================================
+ Hits        16370    16376       +6     
- Misses        605      606       +1     
Flag Coverage Δ
unit 96.43% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants