-
Notifications
You must be signed in to change notification settings - Fork 11
Stop writing UploadLevelTotals
#671
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #671 +/- ##
==========================================
- Coverage 97.94% 97.93% -0.01%
==========================================
Files 435 434 -1
Lines 36925 36581 -344
==========================================
- Hits 36165 35827 -338
+ Misses 760 754 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #671 +/- ##
==========================================
- Coverage 97.94% 97.93% -0.01%
==========================================
Files 435 434 -1
Lines 36925 36581 -344
==========================================
- Hits 36165 35827 -338
+ Misses 760 754 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
==========================================
- Coverage 97.99% 97.98% -0.01%
==========================================
Files 476 474 -2
Lines 38251 37907 -344
==========================================
- Hits 37483 37145 -338
+ Misses 768 762 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 38 files with indirect coverage changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #671 +/- ##
==========================================
- Coverage 97.94% 97.93% -0.01%
==========================================
Files 435 434 -1
Lines 36925 36581 -344
==========================================
- Hits 36165 35827 -338
+ Misses 760 754 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I believe these are completely unused. They were still being created/updated though.
754249a
to
d0fb6ee
Compare
@Swatinem do we still need this? |
I would like to still do this, yes. Though I believe I have hit a roadblock back then when working on the API changes. |
I believe these are completely unused. They were still being created/updated though.