Skip to content

Added R code blocks, huge partion of tutorials covered -c #11537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cemdusenkalkan
Copy link

added total of 35 R code blocks,
I <3 C

@trivialfis trivialfis self-requested a review June 27, 2025 04:43
@cemdusenkalkan
Copy link
Author

@trivialfis any problems with the tests?

@trivialfis
Copy link
Member

No issue there. It's a Java document test, not related to this PR. We are still looking into it.

@trivialfis trivialfis self-assigned this Jul 1, 2025
@trivialfis
Copy link
Member

trivialfis commented Jul 1, 2025

Hi, did you try to verify the examples you or the LLM wrote? Asking because there's no enable_categorical in R.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify the correctness of all examples.

@trivialfis trivialfis removed their assignment Jul 2, 2025
@cemdusenkalkan
Copy link
Author

Hi, did you try to verify the examples you or the LLM wrote? Asking because there's no enable_categorical in R.

#9810 --> maybe should comment them out, not implemented yet. Or I'll delete it, and keep this comment as a reminder

Copy link
Author

@cemdusenkalkan cemdusenkalkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sliced out some of the incoming features of R package, didn't know they were not there since not using a lot in R

@cemdusenkalkan cemdusenkalkan requested a review from trivialfis July 3, 2025 07:45
@trivialfis
Copy link
Member

sliced out some of the incoming features of R package, didn't know they were not there since not using a lot in R

Hi, I think you can try to use the R package before writing examples for others. The features are in the latest package, but you need to figure out how to use them through the existing document and code before adding new examples to the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants