Add environment variable support to SDK resolvers #12023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Jun 16, 2025
rainersigwald
changed the title
|
Ok the logging is Not Quite Right™️:
|
surayya-MS
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
Overall looks good to me!
For logging maybe only log success message "SdkEnvironmentVariableSet" because there would be a lot of repetitions of messages like above. Haven't thought of a better way.
@baronfel , @rainersigwald is my understanding correct that next steps are the following?
|
@surayya-MS exactly! |
|
We should probably make the requirement for 3 explicit: 2.5. Wait until that SDK resolver is inserted into VS int preview. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable dotnet/roslyn#78939 by adding the ability for SDK resolvers to return environment variables.
The environment variables are set during execution, because they cannot be reliably set during evaluation, which may be happening concurrently within a process. The value is also set as a regular property for ease of access during evaluation time.