Smaller thread stack size for copy threads #12065
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the stack size for threads used in synchronous copy operations to save memory on resource-constrained machines.
- Adjusts thread creation by specifying a 64KB stack size.
- Adds a comment explaining the rationale for the new stack size setting.
| Thread newThread = new Thread(ParallelCopyTask); | ||
|
|
||
| // specify the smallest stack size - 64kb | ||
| Thread newThread = new Thread(ParallelCopyTask, 64 * 1024); |
There was a problem hiding this comment.
[nitpick] Consider defining the stack size (64 * 1024) as a named constant to improve readability and ease future modifications.
Suggested change
| Thread newThread = new Thread(ParallelCopyTask, 64 * 1024); | |
| Thread newThread = new Thread(ParallelCopyTask, DefaultStackSize); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We spawn a handful of threads to handle synchronous copying. These threads don't need the default stack size, and we can specify a smaller one to save some space for resource constrained machines.
Changes Made
Testing
Notes