Removed double-click handler that caused folders to auto-open (#15868)

[kachurun]

Removed double-click handler that caused folders to auto-open after close

What it does

Check this issue (#15868)

How to test

Check this issue (#15868)

Follow-ups

Breaking changes

• This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[rschnekenbu]

Hi @kachurun, thanks for your contribution!
In order to be reviewed and accepted, it would need at least to pass the linting, the Eclipse Foundation contributor agreement to be signed by you, and that project still compiles.
You will find some information here: https://github.com/eclipse-theia/theia/blob/master/CONTRIBUTING.md

I converted the Pull Request to a draft until you can address these issues. This facilitates our work to triage the opened pull requests.

[kachurun]

@rschnekenbu

Oh yes, my bad - it was a bad idea to remove dbl click handler handler, since it could be used in classes that extend TreeWidget. I’ve brought this method back and removed only the openNode call.

Now it's only one line of code changed - can't imagine what could go wrong with lints (it compiles successfully locally).

The Eclipse Foundation contributor agreement was signed off by me.

[tsmaeder]

This will turn off double click handling for all nodes in all tree widgets. This is not what we want. Also, in general, one does not know what adopters might want to do upon double click on parent items.
The right place to fix this, IMO, would be in the FileNavigatorModel or FileTreeMode, overriding doOpen()

[kachurun]

Can you please tell me how to find the place where a double-click should open the tree (and a single click doesn't do that)?
I even found some settings for how to open trees with a single or double click, but they don't have any effect in any of the places I tested.

And we have the same bug in the user settings section, for example, and in other places, I guess.

[tsmaeder]

The tree delegates opening the node to its model. The model is different for different tree widgets. The model used in the navigator view is called `FileNavigatorModel".