Move SSH feature to own package #15875
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msujew i think something might still be broken. At least for me it does not call the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #15670
Splits the SSH feature from the
@theia/remotepackage into its own@theia/remote-sshpackage. Does so for better separate of concers and to allow adopters to add remote features without automatically adding the SSH features into the application.How to test
Confirm that the Remote SSH feature still works as expected. Removing
@theia/remote-sshfrom the electron example app package should still allow to use the other remote (WSL, Dev-Container) features, while removing only the SSH related features.Review checklist
Reminder for reviewers