add passive: false explicitly as default opt
#1133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `passive: false` explicitly as default opt to remove below warning in echarts: - [Violation] Added non-passive event listener to a scroll-blocking 'mousewheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952 choose `passive: false` rather than `passive: true` is to avoid below error when doing dataZoom - `Unable to preventDefault inside passive event listener invocation.` Although there are annotations on no neat way to using passive, I personally think it is higher priority to make this great package without warining and error, rather than not doing anything but endless wait to deal with this tiny potential performance issue. Just my two cents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
passive: falseexplicitly as default opt to remove below warning in echarts:choose
passive: falserather thanpassive: trueis to avoid below error when doing dataZoomUnable to preventDefault inside passive event listener invocation.Although there are annotations on no neat way to using passive, I personally think it is higher priority to make this great package without warining and error, rather than not doing anything but endless wait to deal with this tiny potential performance issue. Just my two cents.