Skip to content

Commit 0d21f28

Browse files
jeremy.thomasaarontam
authored andcommitted
ENYO-3019: Remove IE8 Support
Remove log Remove platform ref
1 parent da68949 commit 0d21f28

File tree

4 files changed

+4
-45
lines changed

4 files changed

+4
-45
lines changed

src/AlphaJumper/AlphaJumper.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,7 @@ module.exports = kind(
9898
this.tracking = true;
9999
if (this.hasNode()) {
100100
var b = this.node.getBoundingClientRect();
101-
// IE8 does not return width
102-
var w = (b.width === undefined) ? (b.right - b.left) : b.width;
103-
this.x = b.left + w/2;
101+
this.x = b.left + b.width/2;
104102
}
105103
dispatcher.capture(this);
106104
this.track(event);

src/Arranger/Arranger.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -397,14 +397,7 @@ Arranger.positionControl = function (control, bounds, unit) {
397397
* @public
398398
*/
399399
Arranger.opacifyControl = function (inControl, inOpacity) {
400-
var o = inOpacity;
401400
// FIXME: very high/low settings of opacity can cause a control to
402401
// blink so cap this here.
403-
o = o > 0.99 ? 1 : (o < 0.01 ? 0 : o);
404-
// note: we only care about ie8
405-
if (platform.ie < 9) {
406-
inControl.applyStyle('filter', 'progid:DXImageTransform.Microsoft.Alpha(Opacity=' + (o * 100) + ')');
407-
} else {
408-
inControl.applyStyle('opacity', o);
409-
}
402+
inControl.applyStyle('opacity', inOpacity > 0.99 ? 1 : (inOpacity < 0.01 ? 0 : inOpacity));
410403
};

src/PanZoomView.js

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
var
77
kind = require('enyo/kind'),
88
dom = require('enyo/dom'),
9-
platform = require('enyo/platform'),
109
utils = require('enyo/utils'),
1110
Animator = require('enyo/Animator'),
1211
Scroller = require('enyo/Scroller');
@@ -214,7 +213,7 @@ module.exports = kind(
214213
*/
215214
components: [
216215
{name: 'animator', kind: Animator, onStep: 'zoomAnimationStep', onEnd: 'zoomAnimationEnd'},
217-
{name: 'viewport', style: 'overflow:hidden;min-height:100%;min-width:100%;', classes: 'enyo-fit', ongesturechange: 'gestureTransform', ongestureend: 'saveState', ontap: 'singleTap', ondblclick: 'doubleClick', onmousewheel: 'mousewheel', ondown: 'handleDown', components: [
216+
{name: 'viewport', style: 'overflow:hidden;min-height:100%;min-width:100%;', classes: 'enyo-fit', ongesturechange: 'gestureTransform', ongestureend: 'saveState', ontap: 'singleTap', onmousewheel: 'mousewheel', ondown: 'handleDown', components: [
218217
{name: 'content'}
219218
]}
220219
],
@@ -468,17 +467,8 @@ module.exports = kind(
468467
params = utils.mixin({translate: this.bounds.left + 'px, ' + this.bounds.top + 'px'}, params);
469468
}
470469
dom.transform(this.$.content, params);
471-
} else if (platform.ie) {
472-
// IE8 does not support transforms, but filter should work
473-
// http://www.useragentman.com/IETransformsTranslator/
474-
var matrix = '"progid:DXImageTransform.Microsoft.Matrix(M11='+scale+', M12=0, M21=0, M22='+scale+', SizingMethod=\'auto expand\')"';
475-
this.$.content.applyStyle('-ms-filter', matrix);
476-
this.$.content.setBounds({width: this.bounds.width*scale + 'px', height: this.bounds.height*scale + 'px',
477-
left:this.bounds.left + 'px', top:this.bounds.top + 'px'});
478-
this.$.content.applyStyle('width', scale*this.bounds.width);
479-
this.$.content.applyStyle('height', scale*this.bounds.height);
480470
} else {
481-
// ...no transforms and not IE... there's nothin' I can do.
471+
// ...no transforms means there's nothin' I can do.
482472
}
483473

484474
//adjust scroller to new position that keeps ratio with the new content size
@@ -547,26 +537,6 @@ module.exports = kind(
547537
this.ratioX = this.ratioY = null;
548538
},
549539

550-
/**
551-
* Normalizes the event and forwards it to
552-
* [singleTap()]{@link module:layout/PanZoomView~PanZoomView#singleTap}.
553-
*
554-
* IE 8 Only
555-
*
556-
* @private
557-
*/
558-
doubleClick: function (sender, event) {
559-
//IE 8 fix; dblclick fires rather than multiple successive click events
560-
if (platform.ie==8) {
561-
this.tapped = true;
562-
//normalize event
563-
event.pageX = event.clientX + event.target.scrollLeft;
564-
event.pageY = event.clientY + event.target.scrollTop;
565-
this.singleTap(sender, event);
566-
event.preventDefault();
567-
}
568-
},
569-
570540
/**
571541
* Simulates double-tap by watching for two taps within 300ms of each other.
572542
*

src/Slideable.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,8 +336,6 @@ module.exports = kind(
336336
var s = dom.getComputedStyle(node);
337337
if (s) {
338338
return s.getPropertyValue(boundary);
339-
} else if (node && node.currentStyle) {
340-
return node.currentStyle[boundary];
341339
}
342340
return '0';
343341
},

0 commit comments

Comments
 (0)