Change Request: Stop rolling up package

[nzakas]

Environment

HEAD

What problem do you want to solve?

Right now, we're rolling up the files in this package for distribution, we requires us cleaning up duplicate type definitions. This is a lot of work and we're stuck with how we can reference types between files due to these limitations.

What do you think is the correct solution?

Stop rolling up the package. This isn't strictly necessary because it's an ESM-only package, and therefore, we're not getting much extra value from rolling things up.

We can remove Rollup and just have tsc emit both types and code to the dist directory. The end result for plugin users will be the same and it will allow us more flexibility with how we import and define types.

Participation

• I am willing to submit a pull request for this change.

Additional comments

No response

[xbinaryx]

I'll look into this if there is consensus within the team.

[lumirlumir]

I believe this issue aligns with the one I’ve been working on: #367.

While the combination of rollup and dudupe-types is nice, but it introduces unnecessary complexity when working with types.

If this is accepted, it will make the ongoing migration to the @import syntax (#367) much easier.

So, 👍 to this! Let’s move forward.

---

But one thing I’m afraid of is: wouldn’t this be a breaking change?

[nzakas]

But one thing I’m afraid of is: wouldn’t this be a breaking change?

I don't think so. What is it you think would break?

[lumirlumir]

I'm just wondering —

If we remove rollup and rely only on tsc emit, is it still possible to put all type declarations into a single file like index.d.ts, as we did before?

Does the automatically generated index.d.ts file emitted by tsc include all type information like before?

[nzakas]

When doing this with tsc, it will generate an index.d.ts file to go along with the index.js file. There will also be .d.ts files for each individual file, and index.d.ts will import the other .d.ts files as needed.

For a package user, this change is transparent.

[lumirlumir]

Thank you for the explanation.

In that case, I suppose there won’t be any issues if we stop bundling the packages. 👍

[fasttime]

Sounds good to remove the Rollup bundling step to simplify the build process. +1 from me.

[mdjermanovic]

Sounds good to me too 👍

[snitin315]

Marking this as accepted. @xbinaryx Would you like to send a PR?