Skip to content

ref: SentryEnvelopeHeader to swift #5454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Jun 21, 2025

Blocked by #5481

Converts SentryEnvelopeHeader to Swift

#skip-changelog

Copy link

codecov bot commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Project coverage is 8.279%. Comparing base (d38165b) to head (32b9522).

Files with missing lines Patch % Lines
Sources/Swift/Helper/SentrySdkInfo.swift 0.000% 70 Missing ⚠️
Sources/Swift/Tools/SentryEnvelopeHeader.swift 0.000% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d38165b) and HEAD (32b9522). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (d38165b) HEAD (32b9522)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #5454        +/-   ##
=============================================
- Coverage   86.254%   8.279%   -77.975%     
=============================================
  Files          401      370        -31     
  Lines        34863    26872      -7991     
  Branches     15134       57     -15077     
=============================================
- Hits         30071     2225     -27846     
- Misses        4751    24647     +19896     
+ Partials        41        0        -41     
Files with missing lines Coverage Δ
Sources/Sentry/SentryClient.m 9.743% <ø> (-88.723%) ⬇️
Sources/Sentry/SentryEnvelope.m 0.000% <ø> (-89.321%) ⬇️
Sources/Sentry/SentrySerialization.m 0.000% <ø> (-99.164%) ⬇️
Sources/Swift/Tools/SentryEnvelopeHeader.swift 0.000% <0.000%> (ø)
Sources/Swift/Helper/SentrySdkInfo.swift 0.000% <0.000%> (ø)

... and 391 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38165b...32b9522. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noahsmartin noahsmartin changed the title ref: SentryEnvelopeHeader to swift [WIP] ref: SentryEnvelopeHeader to swift Jun 21, 2025
Copy link
Contributor

github-actions bot commented Jun 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.63 ms 1251.82 ms 33.18 ms
Size 23.75 KiB 858.40 KiB 834.64 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2b02431 1229.63 ms 1248.98 ms 19.35 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms
fc0757d 1231.83 ms 1248.98 ms 17.15 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms
d38165b 1211.41 ms 1242.49 ms 31.08 ms
35c962f 1207.61 ms 1235.90 ms 28.29 ms

App size

Revision Plain With Sentry Diff
2b02431 23.75 KiB 850.73 KiB 826.98 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB
fc0757d 23.75 KiB 850.73 KiB 826.98 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB
d38165b 23.75 KiB 855.37 KiB 831.62 KiB
35c962f 23.75 KiB 854.77 KiB 831.02 KiB

@noahsmartin noahsmartin force-pushed the envelopeHeaderSwift branch from 81f011c to 3b3560f Compare June 21, 2025 13:12
@noahsmartin noahsmartin changed the base branch from main to sentrySdkPackageSwift June 21, 2025 13:13
@noahsmartin noahsmartin force-pushed the sentrySdkPackageSwift branch from d0f9518 to c85b627 Compare June 21, 2025 15:56
@noahsmartin noahsmartin marked this pull request as draft June 23, 2025 12:45
Base automatically changed from sentrySdkPackageSwift to sentryExtraPackagesSwift June 23, 2025 18:29
@noahsmartin noahsmartin force-pushed the sentryExtraPackagesSwift branch 4 times, most recently from 1b0eb72 to 82ec5ad Compare June 24, 2025 19:22
Base automatically changed from sentryExtraPackagesSwift to main June 24, 2025 22:04
@noahsmartin noahsmartin force-pushed the envelopeHeaderSwift branch from 3b3560f to 32b9522 Compare June 24, 2025 23:19
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentrySerialization.m

@noahsmartin noahsmartin marked this pull request as ready for review June 24, 2025 23:20
@noahsmartin noahsmartin changed the title [WIP] ref: SentryEnvelopeHeader to swift ref: SentryEnvelopeHeader to swift Jun 24, 2025
@noahsmartin noahsmartin marked this pull request as draft June 25, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant