Skip to content

docs(feedback): add a warning to autoInject property about SwiftUI #5547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

armcknight
Copy link
Member

Should've gone in with #5223. Requires getsentry/sentry-docs#14227 to be merged first.

#skip-changelog

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.224%. Comparing base (035974f) to head (695975e).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5547       +/-   ##
=============================================
+ Coverage   86.199%   86.224%   +0.025%     
=============================================
  Files          407       407               
  Lines        35072     35078        +6     
  Branches     15228     15232        +4     
=============================================
+ Hits         30232     30246       +14     
+ Misses        4793      4786        -7     
+ Partials        47        46        -1     
Files with missing lines Coverage Δ
...ration/SentryUserFeedbackWidgetConfiguration.swift 0.000% <ø> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035974f...695975e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jul 2, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.00 ms 1260.71 ms 20.71 ms
Size 23.74 KiB 874.07 KiB 850.33 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
25f2d2c 1232.02 ms 1242.78 ms 10.76 ms
e18d392 1228.69 ms 1244.43 ms 15.73 ms
b0e13a7 1227.71 ms 1245.88 ms 18.16 ms
55f739c 1226.06 ms 1248.78 ms 22.71 ms
ac4739e 1236.55 ms 1258.89 ms 22.34 ms
32e7197 1226.91 ms 1245.48 ms 18.56 ms
2b02431 1229.63 ms 1248.98 ms 19.35 ms
db9572a 1212.61 ms 1237.73 ms 25.13 ms
5ec90e0 1235.57 ms 1258.45 ms 22.88 ms
701b301 1226.10 ms 1245.57 ms 19.47 ms

App size

Revision Plain With Sentry Diff
25f2d2c 23.75 KiB 866.69 KiB 842.94 KiB
e18d392 23.75 KiB 866.68 KiB 842.93 KiB
b0e13a7 23.75 KiB 860.98 KiB 837.23 KiB
55f739c 23.75 KiB 858.73 KiB 834.98 KiB
ac4739e 23.75 KiB 872.67 KiB 848.92 KiB
32e7197 23.75 KiB 866.69 KiB 842.94 KiB
2b02431 23.75 KiB 850.73 KiB 826.98 KiB
db9572a 23.75 KiB 858.65 KiB 834.90 KiB
5ec90e0 23.74 KiB 872.67 KiB 848.92 KiB
701b301 23.75 KiB 867.16 KiB 843.41 KiB

@armcknight armcknight enabled auto-merge (squash) July 2, 2025 17:18
@armcknight armcknight merged commit 2a9a505 into main Jul 3, 2025
121 of 124 checks passed
@armcknight armcknight deleted the armcknight/doc/feedback-swiftui-note branch July 3, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants