-
-
Notifications
You must be signed in to change notification settings - Fork 266
Update GH actions run vars #3013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3013 +/- ##
==========================================
- Coverage 87.73% 87.70% -0.03%
==========================================
Files 286 286
Lines 9340 9340
==========================================
- Hits 8194 8192 -2
- Misses 1146 1148 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e788bd4 | 1252.45 ms | 1264.48 ms | 12.03 ms |
aba65ca | 1248.83 ms | 1268.30 ms | 19.46 ms |
4fecc12 | 1253.92 ms | 1281.13 ms | 27.21 ms |
3ad66e4 | 1230.44 ms | 1245.08 ms | 14.65 ms |
d783424 | 1265.71 ms | 1277.00 ms | 11.29 ms |
299a3f6 | 1231.02 ms | 1249.00 ms | 17.98 ms |
f79eecf | 1210.25 ms | 1221.65 ms | 11.40 ms |
c5616a6 | 1237.94 ms | 1252.92 ms | 14.98 ms |
db64b25 | 1258.20 ms | 1275.21 ms | 17.01 ms |
be7a831 | 1262.78 ms | 1282.98 ms | 20.20 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e788bd4 | 7.85 MiB | 9.44 MiB | 1.59 MiB |
aba65ca | 8.38 MiB | 9.73 MiB | 1.35 MiB |
4fecc12 | 8.43 MiB | 9.97 MiB | 1.54 MiB |
3ad66e4 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
d783424 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
299a3f6 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
f79eecf | 8.29 MiB | 9.36 MiB | 1.07 MiB |
c5616a6 | 7.85 MiB | 9.42 MiB | 1.57 MiB |
db64b25 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
be7a831 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c73ab67 | 353.82 ms | 408.71 ms | 54.90 ms |
e66e71e | 296.84 ms | 345.43 ms | 48.59 ms |
1c926c2 | 424.57 ms | 493.89 ms | 69.32 ms |
a817b8f | 383.02 ms | 445.17 ms | 62.15 ms |
8a10ab7 | 436.20 ms | 509.43 ms | 73.23 ms |
ef31c7f | 311.39 ms | 359.33 ms | 47.94 ms |
2966d88 | 365.71 ms | 422.50 ms | 56.79 ms |
134c9f8 | 301.40 ms | 352.65 ms | 51.26 ms |
9fe67d5 | 373.80 ms | 444.24 ms | 70.45 ms |
ee0ca56 | 355.35 ms | 421.13 ms | 65.78 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c73ab67 | 6.15 MiB | 7.13 MiB | 999.97 KiB |
e66e71e | 6.06 MiB | 7.09 MiB | 1.03 MiB |
1c926c2 | 6.46 MiB | 7.48 MiB | 1.03 MiB |
a817b8f | 6.16 MiB | 7.14 MiB | 1003.22 KiB |
8a10ab7 | 6.27 MiB | 7.20 MiB | 958.60 KiB |
ef31c7f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
2966d88 | 6.33 MiB | 7.27 MiB | 954.11 KiB |
134c9f8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
9fe67d5 | 6.33 MiB | 7.29 MiB | 987.27 KiB |
ee0ca56 | 6.33 MiB | 7.30 MiB | 992.52 KiB |
@buenaflor Added one more |
@denrase I think the newest commit breaks the CI |
You can ignore this test: It's pretty flaky, I'll have a look there soon |
#skip-changelog
📜 Description
We should not use user modifiable vars in GH run commands directly and without double quotes.