Deprecate use_inertia_instance_props

[skryukov]

While use_inertia_instance_props is a clever way to mimic Rails behavior, it also exposes too much data on the frontend side, which is very dangerous. Therefore, I propose deprecating it.

[bknoles]

exposes too much data on the frontend side

You mean becuase it's calling .to_json without any way to configure it (potentially exposing some fields you shouldn't send to the client)? I don't really use that feature myself, so I want to make sure I understand Problem Land.

[skryukov]

yup, that's the main one, but I can think of cases when you simply memoize something and inertia passes that to FE as well.

[BrandonShar]

I don't use use_inertia_instance_props personally, but I've always seen it as a sharp knife.

I'm fine with discouraging the use of it, but (at the moment at least), I don't think the bar is high enough to deprecate it. Especially since it's opt-in.