Initialize router before components in React #2379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed this fixes it. Thanks! |
This was referenced Jun 17, 2025
pascalbaljet
added a commit
that referenced
this pull request
Jun 18, 2025
|
Follow-up in #2379 |
This was referenced Jun 18, 2025
pascalbaljet
added a commit
that referenced
this pull request
Jun 20, 2025
Remove `setSwapComponent` method and cleanup after PR #2379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #2366 if we try to run make a request with router inside a useEffect() and the page is the first page loaded it will fail because router is not initialized yet because of how react executes the order of useEffects (bottom to top).
To fix it I splitted the router init, adding a setter for the swapComponent handler to set it inside an useEffect (mandatory).