Skip to content

Add throttle to authed password routes #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

valorin
Copy link

@valorin valorin commented Jul 5, 2025

Following up from #157, fair point that the non-authenticated routes in that PR would throttle via IP, which makes them a risk. The Confirm Password and Password Change routes, on the other hand, are both authenticated so the throttle will work based on the User Identifier instead.

Rate limiting these routes is important because they are vulnerable to brute-force attacks if a user's session is hijacked. An attacker who gains access to a user account, can brute-force the user's password to bypass the verification step, or change the password entirely. This would bypass any brute-force monitoring or protections present on the login form.

The risk is relatively low, as an attacker would need to have hijacked the user's account, but it's still a weakness that should be patched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant